Directives refactored - Githubissues

d-oliveros / ngSmoothScroll

AngularJS directives for animating smooth scrolling to elements.

276 stars 110 forks source link

Directives refactored #44

Closed alxdnlnko closed 2 years ago

alxdnlnko commented 9 years ago

Hi. I've refactored directives, made theese changes:

renamed link function arguments according to Angular docs
renamed elem attributes to prevent conflicts with other libs
added a $watch for scrollIf attribute to trigger the scrolling, when it changes
removed unnecessary callbacks validations
read some options from scope rather than attrs

If you have any questions, feel free to ask, I can explane every change I made :)