search

d-pac / restful-keystone

Automatic RESTful API enabler for KeystoneJS
MIT License
160 stars 50 forks source link

Added hack to get url building working on Windows #5

Closed stephenengland closed 4 years ago

stephenengland commented 9 years ago

path.join will return windows path file separator "\ instead of url based separator "/".

http://stackoverflow.com/questions/12722865/using-path-join-on-nodejs-on-windows-to-create-url

Please note:

I only tested this on Windows.

creynders commented 9 years ago

Thanks for the PR, I'll review it ASAP.

creynders commented 9 years ago

Sorry for the long wait, I should have some time this week to review this. I'll keep you updated.

stephenengland commented 9 years ago

It's cool.. my development environment is Windows, but my prod is Linux, so I just manually made this change in my node_modules folder for now. No rush.

jjhesk commented 8 years ago

can you comit this change @creynders

stephenengland commented 7 years ago

Believe it or not, I'm still having to manually edit this file and add the hack when I develop on Windows. :)

hscharitzer commented 7 years ago

Please please please merge the pull request. I really really want to use this + keystone as a quick API server, but having to manually hack my node dependencies is not the way to go. Even if it's windows ;)