search

d-schmidt / hearthscan-bot

🐙🐘🐦🐉🔥🦅🐍🐺 This bot explained cards in reddit.com/r/hearthstone before Reddit killed 3rd party apps. Archived after 8 years on 1.7.2023
https://www.reddit.com/user/hearthscan-bot
MIT License
12 stars 7 forks source link

Adding Hearthstone Top Decks Information #1

Closed evident closed 7 years ago

evident commented 7 years ago

Swapped out Hearthhead for HSTD Changed all token IDs for HSTD ones

d-schmidt commented 7 years ago

Do the tests still complete successfully? https://github.com/d-schmidt/hearthscan-bot/pull/1/commits/8da9a21cf6119e64ab2374ed88d8269fff3e8c56#diff-b284a28710cce90d9d9be3a7f4cabc8eL298 covering https://github.com/d-schmidt/hearthscan-bot/pull/1/commits/8da9a21cf6119e64ab2374ed88d8269fff3e8c56#diff-702b6abf015bfdb4e41308ddd3b297a9R26 looks like it will fail.

evident commented 7 years ago

I wasn't able to test it, I tried installing python and praw but it wasn't working correctly. I'll give it another go. I looked at the links you mentioned, but I'm not sure what you mean by them "covering" certain things. I apologize, I'm not familiar with Python.

d-schmidt commented 7 years ago

Tests covering something is not Python specific: https://en.wikipedia.org/wiki/Code_coverage

To run the tests you need more than praw. The readme hopefully contains everything: https://github.com/d-schmidt/hearthscan-bot/blob/master/README.md

d-schmidt commented 7 years ago

I guess you gave up? Please submit a new request.