search

d-unsed / ruru

Native Ruby extensions written in Rust
MIT License
832 stars 40 forks source link

feat(vm): add thread call gvl functions #34

Closed dovahcrow closed 8 years ago

dovahcrow commented 8 years ago

add thread call gvl functions from ruby vm.

dovahcrow commented 8 years ago

Don't Merge it until ruby-sys upstream accepted my PR and I will modify the Cargo.toml avoiding using raw git repo.

steveklabnik commented 8 years ago

Yes, sorry, it's taking me a while to get around to ruby-sys. I will try to soon.

d-unsed commented 8 years ago

Hi again @doomsplayer!

There're several things I would like to improve in the code.

I'm now preparing for a big 0.8.0 release with many new things introduced there. I will need some time to finish before releasing new version.

So take your time for this and feel free to ping me for some help if you need :)

d-unsed commented 8 years ago

One more important thing to have is documentation. Please add docs with examples to VM::* functions (not needed for binding::vm)

dovahcrow commented 8 years ago

@d-unseductable I'll add docs and tests later

d-unsed commented 8 years ago

Hi @doomsplayer!

I've tested these functions and everything seems to work fine!

Since the new release is coming very soon, I will merge the PR. I'll add docs and tag you on the commit.

Thank you for contribution!