search

d-unsed / ruru

Native Ruby extensions written in Rust
MIT License
832 stars 40 forks source link

Support for Float and Bignum #45

Closed Zapotek closed 7 years ago

Zapotek commented 7 years ago

Could you please add support for Float and Bignum classes when you get a chance?

Cheers

elifoster commented 7 years ago

Fixnum and Bignum are deprecated in ruby 2.4 and replaced by the more general Integer. What version does ruru target @d-unseductable? Are we going to be using and recommending use of the latest version of Ruby?

d-unsed commented 7 years ago

Hi @zapotek @elifoster

@turboladen has recently started implementing Float in ruby-sys steveklabnik/ruby-sys#11

As for Bignum and ruby 2.4. I would like to support the edge ruby version and not support deprecated stuff or something that is going to be removed. It may add overhead having backwards compatibility.

I believe, those developers who are ready to use cutting edge technologies like Rust to increase the performance of their applications, are ok with updating MRI once per year :)

Zapotek commented 7 years ago

Once per year is fine, it's the time of the transition that's the issue. There are usually Gems that take some time to get updated to support the latest Ruby versions and thus keep us outdated for a few months.

Especially in the case of Ruby 2.4 with its internal changes.

turboladen commented 7 years ago

So here's the PR for Float: #46

Zapotek commented 7 years ago

Good enough for now, my need for Bignum went away with the introduction of wrapped data.

Thanks guys, much appreciated.