search

d-unsed / ruru

Native Ruby extensions written in Rust
MIT License
832 stars 40 forks source link

Create the ruby-sys crate #6

Closed steveklabnik closed 8 years ago

steveklabnik commented 8 years ago

This is a big PR, but it's not that big.

Cargo has a convention of -sys packages. The idea is that the low-level stuff should be a package, and then higher-level bindings should be built on top of it.

ruru is that kind of package, and src/unsafe_bindings is really a -sys crate. So, I made one. :smile:

I went ahead and pushed it up, so that nobody else could squat it while we discuss this PR: https://crates.io/crates/ruby-sys If this PR is accepted, I'll make you an owner of the package as well. If you don't want this PR, well, ruby-sys should still exist, imho :smile:

steveklabnik commented 8 years ago

... well apparently this fails the tests. I was just building my own project, I forgot cargo test :sweat_smile:

So, I will fix it tonight or tomorrow, but still worth discussing in the meantime :)

steveklabnik commented 8 years ago

(for an example of a crate structured like this, https://github.com/sfackler/rust-openssl )

d-unsed commented 8 years ago

Wow! Awesome work, @steveklabnik! Do you think we can merge it?

steveklabnik commented 8 years ago

@d-unseductable awesome :smile: Now that I have fixed the bug @malept has found out, feel free to merge once Travis lands. After you do so, I will add you to the crate on crates.io.

d-unsed commented 8 years ago

Thank you very much!

steveklabnik commented 8 years ago

@d-unseductable woo! It appears that unseductable@gmail.com isn't your login email on crates.io though, maybe DM me the one you use?

d-unsed commented 8 years ago

@steveklabnik, just double checked my crates.io profile! unseductable@gmail.com is the email used for my account. Do you get any errors regarding the email address?

steveklabnik commented 8 years ago

I mis-read the erorr message, you need the login name, not email. You should have just been added.

d-unsed commented 8 years ago

Yes it works, thanks! Also if you want I can add you to this repo's collaborators, what do you think?

steveklabnik commented 8 years ago

Sure, if you'd like :) I'd like to do some more work on this, but I also am interested in how you feel about things. I will probably open some issues for discussions later in the week.