search

d-unsed / ruru

Native Ruby extensions written in Rust
MIT License
832 stars 40 forks source link

Add RString#new_utf8 and string::new_utf8 #71

Closed mjc-gh closed 6 years ago

mjc-gh commented 7 years ago

These functions will return a new Ruby string with UTF8 encoding. This is for the issue described in d-unseductable/ruru#67

d-unsed commented 7 years ago

Thank you! Looks like this PR needs a new version of ruby-sys. I will release it and re-run the CI builds.

turboladen commented 6 years ago

FWIW, it'd be nice to have this merged. We're using ruru in a Rails stack to build data that's used in PDF; part of what's included in that is the trademark symbol. Without this fix, we get ASCII encoding errors; with the fix we're good.

d-unsed commented 6 years ago

Yes, let's do it. I just wanted to merge few more patches to ruby-sys 0.3 related to static libs before starting using it in ruru. But the things take a bit longer than I expected. So I'll simply update ruby-sys dependency and merge this commit

turboladen commented 6 years ago

Awesome!

On Dec 15, 2017, at 13:19, Dmitry Gritsay notifications@github.com wrote:

Yes, let's do it. I just wanted to merge few more patches to ruby-sys 0.3 related to static libs before starting using it in ruru. But the things take a bit longer than I expected. So I'll simply update ruby-sys dependency and merge this commit

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

d-unsed commented 6 years ago

@mikeycgto, could you please rebase the branch?

mjc-gh commented 6 years ago

Sorry for the delay, should be rebased! Thanks for getting this merged in @d-unseductable 👍

d-unsed commented 6 years ago

Thank you, @mikeycgto