search

d-velop / dvelop-app-template-cs

This template contains everything you need to write an app for d.velop cloud in C#
Apache License 2.0
16 stars 7 forks source link

Fix compiler warning NETSDK1071 #22

Closed hangy closed 4 years ago

hangy commented 5 years ago

According to https://aka.ms/sdkimplicitrefs, ASP.NET Core should use implicit package versions and only restrict the version using RuntimeFramework.

hangy commented 5 years ago

@ckuetbach regarding today's discussion: I was able to successfully deploy this PR's branch to AWS lambda: https://48bxyvz559.execute-api.eu-central-1.amazonaws.com/prod/hangy-netsdk/ So it seems that the RuntimeFramework element is enough to satisfy AWS Lambda's .NET Core version restriction.

ckuetbach commented 5 years ago

@hangy thanks for you PR.

It works as expected, but I still have a question. You mention (and changed) RuntimeFramework. But at the provided link, there is only a describtion for a RuntimeFrameworkVersion element.

Was this a mistake? Or do you have another Documentation about RuntimeFramework?

hangy commented 5 years ago

No, you're absolutely right. I'm a bit confused that this change worked in the first place. 😕 I've replaced RuntimeFramework with RuntimeFrameworkVersion, so that this issue should be fixed.

ckuetbach commented 5 years ago

I think this would not be the same, because it is meant exact the oposite way.

The runtime must be that version or newer, but we nee to ensure, that we do use feature of newer versions.

I hink https://github.com/dotnet/sdk/issues/2602 this would be helpful.

ckuetbach commented 4 years ago

I will close this Issue as won't fix, because with dotnet core 3.1 a lot of tooling will change.

See: https://github.com/d-velop/dvelop-app-template-cs/issues/49 and https://github.com/aws/aws-lambda-dotnet/issues/554