d-wasserman / Complete_Street_Rule

The Complete Street Rule for ArcGIS CityEngine is a scenario oriented design tool intended to enable users to quickly create procedurally generated multimodal streets.
https://geonet.esri.com/docs/DOC-6915
Apache License 2.0
169 stars 33 forks source link

Update TOD rule #6

Closed d-wasserman closed 5 years ago

d-wasserman commented 5 years ago

Pull Request to Branch of Complete Street Rule for TOD Update.

Comment by @lexieleileiduan

I'm not sure whether the Initial_Bus/Rail_FAR_Bonus was calculated the right way. Can you verify that? It would be a quick fix if we need to change anything.

The forms seem quite similar, do we need other criteria?

d-wasserman commented 5 years ago

@lexieleileiduan

Can you clean up the the inspector? I see duplicate transit variable types, but I am not sure which one works. When I edit both of them, I did not see any changes. Any suggestions on things to try on a test polygon?

lexieleileiduan commented 5 years ago

which ones?

d-wasserman commented 5 years ago

The Transit Settings vs. The TOD Settings you added. @Group("ZONING","Transit Settings",3) @Range(0,5280)@Order(1) @Description("The proximity to transit measured in Feet.") #@Leilei - Miles? attr Proximity_To_Transit = 500 @Range(0,5280)@Order(2) @Description("The step interval for which transit proximity and transit bonuses are recalculated. For example, if 500, the increments for height bonuses are calculated at 500, 1000, 1500, etc feet.") attr Proximity_Increment = 500 @Range(0,10)@Order(3) @Description("This is a linear decrease factor in the density bonus.") attr Proximity_Linear_Decay_Factor = 1 @Range(0,10)@Order(4) @Description("This is an expoential decreasee factor in the density bonus.") attr Proximity_Exponential_Decay_Factor = 0 @Range(0,100)@Order(5) @Description("This represents the number of high frequency routes within proximity to the target parcel.") attr Number_Of_High_Frequency_Routes = 1 @Range(0,100)@Order(6) @Description("Additional height in stories per height increment.") attr Height_Bonus_Per_Service_Increment = 2 # How does this impact setbacks? Do you want to add a parameter for that?

Maybe we should place the TOD Settings under @Group(Zoning, Bus...etc), and move it up. We can replace the transit settings that were in there previously.

Do I modify the TOD settings to get the building forms to change?

lexieleileiduan commented 5 years ago

Ahh I see.. I forgot you created some decay and increment variables already.. I did not use them but created new ones. Yep change the TOD settings to change the height. The control of TOD is only about height at this point. There is a group "temporary", that contains two variables that I think we will need in the parcel data, for now they are placeholders for the actual values. the Z_FAR is the existing FAR based on zoning. We then calculate bonus FAR. Total bonus far = bus bonus far + rail bonus far. The final FAR used to generated building is the sum of both. Bus/rail bonus FAR is calculated with the _get_Bonus FAR function (probably not the exact name? but it's the last function in the rule). If you change the increment or decay in the TOD settings height will change.

lexieleileiduan commented 5 years ago

I will clean up the inspector tonight. Can you also check the attribute settings in the TOD? especially the two with case scenarios. I wanna make sure they are what you were talking about. Do we need more control over form changes? more than just height? how detailed?

d-wasserman commented 5 years ago

I will start checking the attributes for the TOD settings. I did not get them to change much of the building behavior, so maybe checking that would be good to do before. I might have missed something though, so I will check this weekend.

Just height might be good for now, we can talk about next steps in the presentation for more functionality based on feedback.