search

d-widget-toolkit / dwt

A library for creating cross-platform GUI applications.
141 stars 33 forks source link

Add AccessibleAttribute classes #87

Closed summer-alice closed 3 years ago

summer-alice commented 3 years ago

This translates the Java versions of the AccessibleAttributeAdapter, AccessibleAttributeEvent, and AccessibleAttributeListener classes to D.

The code is the same for both win32 and Gtk.

As an aside, have you given any thought to reorganizing the repository structure (ref #77)? While it's no issue for me duplicating the code, you've previously said smaller diffs are better.

(not trying to rush you by asking this)

jacob-carlborg commented 3 years ago

Thanks.

jacob-carlborg commented 3 years ago

As an aside, have you given any thought to reorganizing the repository structure (ref #77)? While it's no issue for me duplicating the code, you've previously said smaller diffs are better.

No, not really. I guess the most natural way would be to follow the same structure as the SWT git repository.

summer-alice commented 3 years ago

Thanks.

Thank you.

summer-alice commented 3 years ago

As an aside, have you given any thought to reorganizing the repository structure (ref #77)? While it's no issue for me duplicating the code, you've previously said smaller diffs are better.

No, not really.

No worries :-)

I guess the most natural way would be to follow the same structure as the SWT git repository.

I don't have any objections to that, the only issue I see with it is a large dub.sdl file -- if I'm correct in assuming this would require changes to the sourcePaths tag.

jacob-carlborg commented 3 years ago

I see with it is a large dub.sdl file -- if I'm correct in assuming this would require changes to the sourcePaths tag.

Yes, it would require changes to sourcePaths. It would require adding 10-11 entries to sourcePaths. I don't think that's a big problem.

summer-alice commented 3 years ago

It would require adding 10-11 entries to sourcePaths. I don't think that's a big problem.

I probably shouldn't have said "issue" since it's not really, rather it's just the only downside I could think of compared to a separate directory which contained the "common" stuff, since (in theory) this would only require one new entry for each configuration.

In the end there is no real difference, so when you've decided on a layout let us know :)

jacob-carlborg commented 3 years ago

so when you've decided on a layout let us know :)

I apologize for the delay. Let's go with the same structure as the SWT repository.

summer-alice commented 3 years ago

I apologize for the delay.

Same here.

Let's go with the same structure as the SWT repository.

No worries, I'll create a draft pull request soon.