Update CTabItem to 4.7.3

[summer-alice]

Moves the CTabItem class into the new "common" directory, and updates the code to match SWT version 4.7.3.

[summer-alice]

okay... not entirely sure why those snippets decided to fail now. I don't think it's something I've done, but will have a look.

[summer-alice]

A quick follow through of the imports and it seems that the alias to!(string) toString previously declared in CTabItem[1] was being publicly imported in org.eclipse.swt.all[2], which in turn was imported in the snippets[3].

I think it's probably better to change the snippets to use to!string(). Did you want me to change it in a separate pull request or just change it in this one?

[jacob-carlborg]

I think it's probably better to change the snippets to use to!string(). Did you want me to change it in a separate pull request or just change it in this one?

Apologies for the late reply. Isn't it better to have a toString function? It would result in less changes compared to SWT. But I think it's your call, you're doing most of the work now.

[summer-alice]

Apologies for the late reply.

No worries.

Isn't it better to have a toString function? It would result in less changes compared to SWT.

Yea that is true.

But I think it's your call, you're doing most of the work now.

I'll move the alias to base/src/java/lang/String.d since, to me, that makes the most sense (the other D-to-Java string related functions are there).

[jacob-carlborg]

I'll move the alias to base/src/java/lang/String.d since, to me, that makes the most sense (the other D-to-Java string related functions are there).

Sounds good.

[summer-alice]

Okay, the CI passes now. It took a while to complete because one of the VM's took a while to start up.

[jacob-carlborg]

🙇

[summer-alice]

Thank you.