search

d-zone-org / d-zone

An ambient life simulation driven by user activity within a Discord server
ISC License
573 stars 75 forks source link

Update all dependencies #248

Closed d-zone-maintenance[bot] closed 3 years ago

d-zone-maintenance[bot] commented 3 years ago

An updated update of all NPM dependencies.

vegeta897 commented 3 years ago

@SagnikPradhan I think an update to either superstruct or typescript has broken yakshaving.

From the netlify build log:

7:26:48 PM: source/modules/configuration/schema-types.ts(79,14): error TS2322: Type 'Struct<{ projectRoot: string; entryPoint: string | string[] | Record<string, string>; outputDirectory: string; additionalPlugins: any[]; advanced?: { ignoredDependencies?: string[] | undefined; rollupOptions?: { ...; } | undefined; pluginOptions?: { ...; } | undefined; } | undefined; }, { ...; }>' is not assignable to type 'Struct<Configuration, unknown>'.
7:26:48 PM:   Types of property 'TYPE' are incompatible.
7:26:48 PM:     Type '{ projectRoot: string; entryPoint: string | string[] | Record<string, string>; outputDirectory: string; additionalPlugins: any[]; advanced?: { ignoredDependencies?: string[] | undefined; rollupOptions?: { ...; } | undefined; pluginOptions?: { ...; } | undefined; } | undefined; }' is not assignable to type 'Configuration'.
SagnikPradhan commented 3 years ago

Oh Boy. Will look into it.

vegeta897 commented 3 years ago

After some testing with the newest superstruct and typescript versions in another repo, I have determined that superstruct@0.11.1 seems to be incompatible with typescript@4.1.2 at least for TS's type checking in the way we are using it. Updating either dependency to the latest version is fine but doing both leads to the error. In my repo I opted to update TS and wait for a fix before updating superscript again.

The failing tests on this issue are possibly indicative of the current incompatibility.

SagnikPradhan commented 3 years ago

Why does netlify still fail here?

vegeta897 commented 3 years ago

Why does netlify still fail here?

I haven't made any changes yet, just commenting what I already told you on Discord and proposing a solution.

SagnikPradhan commented 3 years ago

Why does netlify still fail here?

I haven't made any changes yet, just commenting what I already told you on Discord and proposing a solution.

Oh LOL. I see.