d0c-s4vage / lookatme

An interactive, terminal-based markdown presenter
https://lookatme.readthedocs.io/en/latest/
MIT License
2.08k stars 61 forks source link

v3.0 - The styles `styles.slides.{fg,bg}` should modify the slide background #165

Closed d0c-s4vage closed 1 year ago

d0c-s4vage commented 1 year ago

Describe the bug The styles styles.slides.{fg,bg} currently modifies the slide number text in the bottom-right corner. This is confusing - it should be modifying the background of the slides and the default foreground of the slide text.

A separate style should be added for slide_number with its own fg and bg.

Expected behavior The default slide text foreground should be red when set to #f00. The entire slide's background should be set to the background color.

Environment (please complete the following information):

Notes This may have to wait for 3.0 in order to implement this properly. It would be impossible to have cascading styles in 2.x - 3.0's new Context object can handle this correctly.

Tips

When creating the main slide frame in lookatme/tui.py, we need to: