search

d0k3 / GodMode9

GodMode9 Explorer - A full access file browser for the Nintendo 3DS console :godmode:
GNU General Public License v3.0
2.15k stars 194 forks source link

[FEATURE REQUEST] Add "Verify file and fix" to NCSD Image Options #609

Closed danielberwick closed 4 years ago

danielberwick commented 4 years ago

When converting a large library of decrypted 3ds files, the ability to fix poorly decrypted ROMs is fantastic.

You can select multiple ROMs to convert or to verify and it will run them as a batch. However, there's no 'batch' option for .3ds files that require fixing as it requires user input for each file that needs fixing.

It would be extremely helpful if this could be automated in a separate option to "Verify and Fix" where it will automatically try and fix a list of 3ds files without a per-file user prompt. This way, a large list can be fixed overnight without pausing.

Of course, this just a friendly suggestion and a really nice to have. It's a privilege to have access to such an amazing tool as it is, and I utterly appreciate the devs and community for supporting it. Thank you.

d0k3 commented 4 years ago

I can make that a default setting. In other words, you'll be asked once, but your answer will be remembered for all fixable NCSDs until you reboot. How does that sound?

danielberwick commented 4 years ago

I can make that a default setting. In other words, you'll be asked once, but your answer will be remembered for all fixable NCSDs until you reboot. How does that sound?

That sounds absolutely perfect. Thank you.

d0k3 commented 4 years ago

@danielberwick - I've got something for you to try.

https://f.secretalgorithm.com/9lz1v/godmode9-v1.9.1-74-gda10a1b1-20200731114630.zip

This will give you an additional option when a bady decrypted file is found on verification. Please try!

danielberwick commented 4 years ago

@danielberwick - I've got something for you to try.

https://f.secretalgorithm.com/9lz1v/godmode9-v1.9.1-74-gda10a1b1-20200731114630.zip

This will give you an additional option when a bady decrypted file is found on verification. Please try!

Thank you again, I'll download this and give it a try today.

d0k3 commented 4 years ago

Reopened - we'll wait until @danielberwick has tested this.

danielberwick commented 4 years ago

I'm just moving a batch of 3ds files that need fixing over to a new xl. I'll test a small batch first, then run a larger overnight run and report back.

danielberwick commented 4 years ago

Initial testing gone well for this functionality. It's gone through a small batch of 3ds files without a problem and didn't ask for further verification.

One possible defect I noticed in the build (which doesn't seem directly related to the verify functionality), this version of GM9 wouldn't load at startup with Luma 10.1 but worked fine once I upgraded Luma to 10.2.

danielberwick commented 4 years ago

@d0k3

Large 3ds verify and fix all batch ran overnight, they're all converting now without an issue.

I also ran the fix once option and it requested verification for the next fix, so that looks good too.

The feature's looking great!

d0k3 commented 4 years ago

That's great, thank you! We can close this then.

d0k3 commented 4 years ago

I just noticed you also had an issue booting this build in Luma 10.1 - was this on a N3DS console? Maybe you could help us with some testing on that (currently in the process of fixing that issue for good)?

danielberwick commented 4 years ago

I just noticed you also had an issue booting this build in Luma 10.1 - was this on a N3DS console? Maybe you could help us with some testing on that (currently in the process of fixing that issue for good)?

It was on a New 3DS XL. I'd be very happy to help out with testing. I'll have to see if I can roll back the Luma version.

d0k3 commented 4 years ago

Alright we already got that fixed. Thanks for your offer for testing!