Margen67
commented
3 years ago One problem with this: because the devkitarm docker image comes with an older version of git (or at least I think that's why), checkout v2 can't properly clone the repo and instead does it with github's rest API, which leaves out the entire .git folder. This in turn prevents gm9's Makefile from having any information on what commit is being built, so the resulting build artifact will be missing everything derived from that (this can be seen in the artifact produced by the CI build run on this pull request).
Other than that, these changes are fine. I would recommend simply leaving it using checkout v1, as I do no know of any downside to doing so.
@aspargas2 Checkout v2 does a shallow clone by default:
# Number of commits to fetch. 0 indicates all history for all branches and tags.
# Default: 1
fetch-depth: ''
One problem with this: because the devkitarm docker image comes with an older version of git (or at least I think that's why), checkout v2 can't properly clone the repo and instead does it with github's rest API, which leaves out the entire .git folder. This in turn prevents gm9's Makefile from having any information on what commit is being built, so the resulting build artifact will be missing everything derived from that (this can be seen in the artifact produced by the CI build run on this pull request).
Other than that, these changes are fine. I would recommend simply leaving it using checkout v1, as I do no know of any downside to doing so.