search

d0k3 / GodMode9

GodMode9 Explorer - A full access file browser for the Nintendo 3DS console :godmode:
GNU General Public License v3.0
2.12k stars 191 forks source link

Loading from certs.db more accordingly + extra Certificate functions #704

Closed luigoalma closed 3 years ago

luigoalma commented 3 years ago

Instead of guessing offsets, we can load more accordingly by reading the DIFF image and parsing the partitionA data. This ensures we can find cert, given its imported on the db and the partitionA data is sane. Even in the cases of imported custom cert names, or dev and retail imported certs mixed in, like in a dev console installing homebrew with the retail certs on cia installs. Before merge, this could be possibly optimized to not look every time for certs and only once, at least for the default dev and retail certs, but right now, its put up for testing and ensuring it works generally. A bit of testing appears to show it being functional, however further testing by anyone would be always welcomed.

d0k3 commented 3 years ago

Also, sorry about the radio silence. Real life and stuff :^).

luigoalma commented 3 years ago

No problems on the silent! Alright lets see about some of these change requests

luigoalma commented 3 years ago

There's still something I'd like to implement before merge. Saying in case change requests and reviews pass before I do.

luigoalma commented 3 years ago

I believe I done all the edits I can think of, now its just waiting review, and extra code change requests if any. Also testing by anyone interested in testing it too, even if tests seem to pass correctly on my side, extra testing is welcome.

d0k3 commented 3 years ago

Alright, after another review, this looks good to me. Would you be okay with squashing this to fewer commits before the merge? Sorry about being a bit slow these days, too.

So, @luigoalma, is this ready to be merged?

luigoalma commented 3 years ago

It's now squashed to 7 commits, it's about as much as I can safely rewrite history and squash them, unless you'd like them to be squashed to 1 commit. And yes, at least by me, it's ready to merge.

d0k3 commented 3 years ago

Merged with current master. Thanks for your contribution!