search

d0k3 / GodMode9

GodMode9 Explorer - A full access file browser for the Nintendo 3DS console :godmode:
GNU General Public License v3.0
2.14k stars 193 forks source link

Set transparent pixels in DS icon to white #710

Closed RayyanAnsari closed 3 years ago

RayyanAnsari commented 3 years ago

This PR sets the first entry in the DS icon palette to white (like in the 3DS Home Screen). Example with my Dr. Kawashima's Brain Training: How Old Is Your Brain? cart. Before: snap_210604112826 After: snap_210604112843

Here is an image of how it looks on the 3DS Home Screen: 2021-06-04_12-32-19 444_bot

d0k3 commented 3 years ago

Wouldn't it be better to set that pixel to black? (same as the GodMode9 background color)

RayyanAnsari commented 3 years ago

Wouldn't it be better to set that pixel to black? (same as the GodMode9 background color)

@d0k3 we could, but in my opinion it would be better to show icons how they are displayed on the 3DS (and DSi) home screen. On the DS, it is transparent, but behind it is a white/grey gradient. I don't know any icons like this, but some icons may not look good on a black background with (fake) transparency because the icons were designed to be in front of a white-ish background.

aspargas2 commented 3 years ago

For what it's worth, I'm inclined to agree with setting them to white for consistency with the home menu.

Wolfvak commented 3 years ago

@WaluigiWare64 in the interest of consistency, can you preserve the palette[0] value and restore it before returning? Thanks!

d0k3 commented 3 years ago

Alright ,sorry, I know this took long. I'm requesting one small change...

d0k3 commented 3 years ago

Merged to master. Thanks for your contribution! (and sorry this, again, took so long)