Closed ZeroSkill1 closed 3 years ago
After some more testing, it seems that it works fine with DSiWare CIAs, too.
before:
00030015534C524E TWiLight Menu++ (TWL-SLRN) (DSi Exclusive) (W) (v0.0.0).standard.cia
after:
00030015534C524E TWiLight Menu++ Last-run ROM (TWL-SLRN) (DSi Exclusive) (W) (v0.0.0).standard.cia
Thanks, good addition!
To better understand what this fixes, let's take a look at what happens when renaming this NDS file to good name:
![og_result](https://user-images.githubusercontent.com/18742654/124441182-19034b80-dd84-11eb-93be-f20176f6a1ec.png)
The result is a cut-off name, because currently, the name is copied only until the first newline. NDS/DSi Names consist of![grafik](https://user-images.githubusercontent.com/18742654/124441566-78f9f200-dd84-11eb-8946-b65c87fa2e8d.png)
Title + Publisher
in one string. However, to avoid overlapping, parts of the Title and the Publisher are separated by newlines, as seen here:and this is what the Title looks like, if we were to interpret it as a string:
Therefore, every character until the last newline is still part of the Title, because what comes after the last newline is the Publisher.
I have implemented it like this:
And as a result:
It now correctly renames the Title, it is no longer cut off.