search

d0k3 / GodMode9

GodMode9 Explorer - A full access file browser for the Nintendo 3DS console :godmode:
GNU General Public License v3.0
2.12k stars 191 forks source link

Improved markdown viewer feature #740

Closed pokemaniac05 closed 2 years ago

pokemaniac05 commented 2 years ago

I added markdown viewer (referred as MD ToC Viewer) feature, as seen in HOME -> More... -> Show ReadME to every .md file in sdcard and other partitions. To view these file, user has to press A and select View in MD ToC Viewer. I also added a Markdown... menu to view files inside 0:/gm9/markdown (like Scripts... and Payloads... menus). Finally I edited Show ReadME to enter .md file name via soft keyboard (to let user view other .md files added to VRAM at compile time).

I tested code changes on Old2DS and they work.

d0k3 commented 2 years ago

There are several issues with this, the most important is: That ToC viewer is not designed for universal support (it does even say so in the source code comments). So, with any given .md file, anything could happen - even if all the files you tested caused no trouble. You also used tabs instead of spaces (GodMode9 uses spaces) and the MD support directory plus the additional HOME menu entry is too much for something that's not a "main" feature (this is still GodMode9, not MarkDown9 now).

That being said, I'm not against a universal Markdown viewer, but it also needs universal compatibility then, and it would need no more integration but the A button menu. Can't merge this like it is, so I'm closing it for now.