search

d0k3 / GodMode9

GodMode9 Explorer - A full access file browser for the Nintendo 3DS console :godmode:
GNU General Public License v3.0
2.12k stars 191 forks source link

Improved markdown viewer (fixed #740) #745

Closed pokemaniac05 closed 2 years ago

pokemaniac05 commented 2 years ago

This PR is a fixed version of #740 I resolved the bug reported by @aspargas2 (now the buffer is initialized with VRAM0_README_MD, as everyone might except) and added security check if given .md file has no captions (that file will be opened by TextViewer instead ToC). I think that @d0k3 was referring to that. Regarding indentation, I noticed that a lot of code (also files that I have not touched) uses, for example, 8 char tabs and two spaces instead of 10 spaces and I have not changed that aspect.

Wolfvak commented 2 years ago

What's exactly the point of this? Our MD reader isn't compliant at all, it barely implements the most minimal subset it can to work with the standard README, and even that has to be modified when building GM9 in order to make it look acceptable?

If you were to implement the full spec then it would make more sense, but it would also be unbearably huge and not worth the effort. Again - GM9 is not designed as a reader, it's only there for some kind of "quick reference"

pokemaniac05 commented 2 years ago

I'm having problems with git and a commit is missing -------- Messaggio originale --------Da: Wolfvak @.>Data: dom 10 ott 2021, 22:48A: d0k3/GodMode9 @.>Cc: pokemaniac05 @.>, Author @.>Oggetto: Re: [d0k3/GodMode9] Improved markdown viewer (fixed #740) (#745) What's exactly the point of this? Our MD reader isn't compliant at all, it barely implements the most minimal subset it can to work with the standard README, and even that has to be modified when building GM9 in order to make it look acceptable? If you were to implement the full spec then it would make more sense, but it would also be unbearably huge and not worth the effort. Again - GM9 is not designed as a reader, it's only there for some kind of "quick reference"

—You are receiving this because you authored the thread.Reply to this email directly, view it on GitHub, or unsubscribe.Triage notifications on the go with GitHub Mobile for iOS or Android.

d0k3 commented 2 years ago

What @Wolfvak wrote - we can't merge this to GodMode9 because the included markdown viewer does not have the compatibility or was ever intended to be a universal markdown viewer. It just works with the readme and provides a convenient way to navigate it, but that's that. Even though I'll have to close this, know that contributions are always appreciated.