search

d0k3 / GodMode9

GodMode9 Explorer - A full access file browser for the Nintendo 3DS console :godmode:
GNU General Public License v3.0
2.09k stars 190 forks source link

Make select prompt scroll if over 10 options #792

Closed Epicpkmn11 closed 1 year ago

Epicpkmn11 commented 1 year ago

Makes the select prompt scroll like the 'new style' file browser if there's more than 10 items in it. Select prompts with fewer than 10 items function exactly as before except I added making the Left/Right buttons jump by 10 items (so for small lists it jumps directly to the top/bottom)

I also made a couple minor changes to the 'new style' file browse code for consistency, the only functionality change is it now wraps with up/down (but not left/right).

Screenshots ## Before ![スクリーンショット 0004-10-14 18 15 39](https://user-images.githubusercontent.com/41608708/195964297-6d154536-47b2-4402-9105-6810d2c69f1f.png) ## After ![スクリーンショット 0004-10-14 21 06 31](https://user-images.githubusercontent.com/41608708/195964298-94bf0125-e2d7-4f0a-aa80-62b193012eff.png)
Wolfvak commented 1 year ago

If there's stray text after the options (say, some genius applied a dumb patch like the one attached to test this) there will be stray text right after the [%d more] string, is this is intended as a "preview" of sorts or a bug?

extra_option.patch.txt

Screencap ![snap_221014233919](https://user-images.githubusercontent.com/29258354/195965214-389e86ba-9caa-4631-a8c7-e3648537c9f8.png)
Epicpkmn11 commented 1 year ago

Fixed:

Screenshot (next line is `kebbbbbbbbbbbbebbbbbbbbbbbb`) ![スクリーンショット 0004-10-14 21 59 30](https://user-images.githubusercontent.com/41608708/195965996-4c896158-cdd0-4400-9d5b-9e7e4dd51352.png)
d0k3 commented 1 year ago

Looks good to me. Merged, thanks both of you!