d0k3 / GodMode9

GodMode9 Explorer - A full access file browser for the Nintendo 3DS console :godmode:
GNU General Public License v3.0
2.09k stars 190 forks source link

[BUG] Pokemon Sapphire save file failed to inject due to incorrect size #794

Closed ohyocbz closed 1 year ago

ohyocbz commented 1 year ago

So you want to report a bug? Hold on, there are ways you could make things easier for us:

Info about your system Include this info to make our work easier:

Help yourself Especially for any kind of boot issue ("GodMode9 doesn't boot"), but also in many other cases these steps make a lot of sense and we will ask you to do them anyways:

Have you actually read this? [X] I have read the information above

d0k3 commented 1 year ago

@ohyocbz - thanks for the bg report! Can you try this test build? GodMode9_794.zip

ohyocbz commented 1 year ago

@ohyocbz - thanks for the bg report! Can you try this test build? GodMode9_794.zip

Hello! Sorry for the long wait and reply. I was also busy irl so it took me quite some time to check this out on my own at night. Here's what happened so far:

  1. The "129kb" save file inject that I uploaded here before was finally working and could play perfectly 😄 20221124_001246 20221124_001325 20221124_001451 20221124_001540

  2. I also did backup the new save to the gm9/out folder and I was surprised that the file size went back to 128kb or its usual bytes size 20221124_001655

  3. I tried to play it on my computer using mGBA emu to continue and save once again and I find it very odd on why the save file size went back to 129kb (I read somewhere that it was for RTC data or sumn so I should probably ignore it when that happens)

  4. So I use this new 129kb save file, put it on my sd card and boot the payload until this message appeared out of the blue: 20221124_003756

  5. i got nervous and thought my sd card got corrupted but im glad my OS repaired it and found no errors. Before I was about to replace the GodMode9.firm from winrar, is it normal for a debug payload firm's file size to be larger after a single use? 20221124_004707

  6. I replaced it and boot up godmode9 and inject the new incorrect size save file and it works like a charm and was indeed playable 20221124_004631

Thank you so much for your time and effort on fixing this 🙇🏻‍♀️

d0k3 commented 1 year ago

Thanks a lot to you for testing this as thorough as you did. You're right, the additional 1kb is some emulator specific RTC data. I've got no way of keeping this data or even restore / use it. Also, no need to worry about it, as you see, mGBA just rebuilds the data when you import the save back.

As for the error and the GodMode9.firm size - I'm at a loss here. Something weird happened to cause this. Maybe you did mix up GodMode9 firms? The file itself should not change size when running.

ohyocbz commented 1 year ago

Thanks a lot to you for testing this as thorough as you did. You're right, the additional 1kb is some emulator specific RTC data. I've got no way of keeping this data or even restore / use it. Also, no need to worry about it, as you see, mGBA just rebuilds the data when you import the save back.

So I'll have to use this test build payload you gave me for the mean time when injecting or dumping my saves with RTC

As for the error and the GodMode9.firm size - I'm at a loss here. Something weird happened to cause this. Maybe you did mix up GodMode9 firms? The file itself should not change size when running.

I think I did mixed up without noticing while transferring, I'll just have to be careful from now on