Adding text editor functionality to text viewer.

nevumx commented 1 week ago

Pursuant to my feature request https://github.com/d0k3/GodMode9/issues/861, I am pleased to present my proposal PR for adding text editor functionality to the existing text viewer by repurposing the existing keyboard that is used for file renames.

Features:

UTF-8 display and typing support
Support for both LF and CRLF line endings, not CR line endings
PGUP/PGDN/HOME/END-style cursor functionality
Full wordwrapped/non-wordwrapped text support
Now allowing Text Viewing/Editing of empty files to create a file from scratch
Works with viewing/editing existing script files/comment coloring
EDIT: Added full clipboard functionality with select/cut/copy/paste features!

Screenshots: snap_240627192950 snap_240627161019 snap_240627161030 snap_240627161239 snap_240627161245

Considerations:

Some functions shared by, for example, the README ToC Viewer and System information viewer has been changed.
- I tested the system information viewer with no issues
- The README viewer seems to have disappeared for some reason, so I couldn't test that... 🤔
In order to fully support editing both wordwrapped and non-wordwrapped text, there were some edge cases that resulted in some unsightly if statements around, for example, when the last line is a certain length.
I tried to get the cursor to blink first by using code like InputWait(1), but that resulted in inputs getting dropped occasionally when pressing a button between InputWait calls when the screen was being drawn.
- I also tried a multi-threaded approach, but even though the code I wrote with <threads.h> compiled, the thread would never spawn due to thrd_error... I am guessing threads are out of scope for this project, since I don't see them anywhere else, definitely open to other suggestions on this...
I renamed the "Textviewer" to "Text Editor," which might look kind of odd next to "Hexeditor;" but "Texteditor" seemed weird too, so I am open to suggestions here too...
Some hardware buttons used on the rename prompt as keyboard hotkeys are different than in the text editor.
- For example, "R" doesn't switch between capslock states, instead it is used to move the cursor further, like with the text viewer.
- ~Instead "Y" switches between capslock states, because I don't see a purpose for a hardware button to insert a space into the text...~ EDIT: I am using "Y" for the new clipboard cut/copy/paste feature.
- "A" Adds a newline char instead of submitting.

Definitely open to suggestions on this, especially as it relates to key bindings/text/etc. ALSO, please do test in any/every way you can think of; I had a reasonably robust set of test files, but it's always possible that there was an edge case I missed. And translations; not sure what can be done in that regard in this PR...

EDIT: I have added clipboard functionality. For example, if we are in this file: snap_240704151448 And we press "L+→", we start a selection: snap_240704151453 Where we can continue this to the end of the line with additional "L+→" or "R+→" presses: snap_240704151457 And go downwards with "L+↓" or "R+↓": snap_240704151504 Then we can copy that text with "Y" or cut it with "R+Y": snap_240704151531 And paste it in again with "Y": snap_240704151535 And paste more times with the same clipboard data: snap_240704151614 And then we can clear the clipboard with "R+Y": snap_240704151618