d0ng1ee / logdeep

log anomaly detection toolkit including DeepLog
MIT License
387 stars 115 forks source link

Possible implementation errors for session_windows #37

Open ZhongLIFR opened 1 year ago

ZhongLIFR commented 1 year ago

Thanks for your work. Deeplog performs very well when I use the "sliding_window" option on HDFS. However, it performs very poorly when I use the "session_window" option on HDFS (Precision: 2.953%, Recall: 99.994%, F1-measure: 5.736%). Could you please double-check whether your implementation of "session_window" is correct? (Please let me know anyone else also had this problem) Thanks

Particularly, you have used the following function to truncate or pad each session for "session_window". From my side, I think it will largely impact the accuracy (Precision or F1-score).

def trp(l, n): """ Truncate or pad a list """ r = l[:n] if len(r) < n: r.extend(list([0]) * (n - len(r))) return r