[Question]Should use master branch for development?

d0p3t / fivem-js

Javascript and Typescript wrapper for the FiveM natives API

https://d0p3t.nl

Other

143 stars 57 forks source link

[Question]Should use master branch for development? #54

Closed imckl closed 3 years ago

imckl commented 3 years ago

I'm about to test my PR to fix any issue in-game. However it throws error which is not the change I've made.

(I've done nothing on /lib/ui/menu/items/UIMenuItem)

This alter the actual test I wanna do, and might be overhead to temporary remove those changes.

So should we create PR-branch based on functional branch(eg. master branch) for development, instead of the development branch?

mythicalbro commented 3 years ago

There have been some changes indeed, but I am always using dev branch and have not had any problems yet with the menu or any other stuff I use. If there is issue then you should try to find out what exactly causes that issue. You should do pull requests to dev branch not master branch.

imckl commented 3 years ago

Thanks, I'll figure that out