search

d0p3t / fivem-js

Javascript and Typescript wrapper for the FiveM natives API
https://d0p3t.nl
Other
143 stars 57 forks source link

Imports patch #9

Closed LemonCaik closed 5 years ago

LemonCaik commented 5 years ago

This should fix the import errors on 1.2.0. Should note that I haven't tested NativeUI after making these changes

d0p3t commented 5 years ago

Would it be possible for you to check if these export changes fix the menu ui issue?

Here's some example code for you to try it with https://github.com/d0p3t/fivem-js/pull/3

You might have to change imports in that example because this uses the old style, but the code itself must work.

LemonCaik commented 5 years ago

It's working with the example code

https://i.gyazo.com/8c0b3ef4ffc5be8ca67b3d24e56a1cbc.mp4

However, if you go into a submenu the submenu cannot be closed. This happens in both 1.1.1 and this PR. Pressing 'm' while in a submenu simply reopens the main menu

d0p3t commented 5 years ago

Thanks. I will push this to npm in an hour or two