d0ugal / metareview

Tools to download and analyse data from Code Review tools
4 stars 1 forks source link

Working with repos besides openstack #3

Open abingham opened 10 years ago

abingham commented 10 years ago

There seem to be problems working with gerrit installations other than open-stack. When I try to fetch data from the Android open-source project I get authorization errors. When I try to fetch from AOKP I get SSL certificate errors after a few fetches (this may be outside our control, of course.) At cyanogenmod I get connection refused.

I know that my tool yapga was able to fetch from these sites in the past (it's been several months since I've tried), so my guess is that there's something goofy with how pygerrit is connecting, or with how review_analysis is using it.

d0ugal commented 10 years ago

Yeah, this is to do with the fact they all customise the authentication one way or another and some of them run old Gerrits. OpenStack is up to date and has the REST API. Some don't even have that.

I need to have another go at this, I'll check out how you do it with https://github.com/abingham/yapga - maybe there is a hybrid approach we can use.

abingham commented 10 years ago

I'm running yapga a few times here to see if it still works like it used to. I'll let you know how that goes.

abingham commented 10 years ago

Yapga does appear to be able to fetch data from all of these troublesome repos mentioned above (as well as from openstack.) All of the auth-related stuff in yapga is in yapga.gerrit_api.create_connection(), and it looks like I do things a bit differently than you and pygerrit, using auth-handlers and openers.

I'm certainly no expert in these authentication issues. I remember spending quite a bit of time searching the internet for the magical invocations that made things work.