d0ugal / python-rfxcom

A Python 3.3+ library for working with your RFXTrx and automating your home.
BSD 3-Clause "New" or "Revised" License
8 stars 9 forks source link

big pack #24

Closed skimpax closed 7 years ago

skimpax commented 7 years ago

Hello,

First, thanks for having created this clean project!

This pull request is quite a big pack of code:

Rule for not supported fields: In these new families my rule was not to output a field which is not handled by a peculiar subtype (when it is supported by some other subtypes) eg. for UltraViolet type, it subtype is not 0x03, do not send 'temperature' field. Otherwise, this would imply to define a non-significant value and put it inside. This would imply the client application having knowledge of this NS value to make decision whether or not there is a valid data. Rule is finally dead simple: no data, no field.

Note: I ran tox on Ubuntu 16.04, so I forced python35 in tox.ini

Christophe.

d0ugal commented 7 years ago

Thanks - this looks good! As you can probably tell, I am not really using this project anymore. I am happy to merge in the changes but it is unlikely that I will use them and/or be able to support them.