search

d11wtq / dockerpty

Pseudo-tty handler for docker Python client
https://github.com/d11wtq/dockerpty
Apache License 2.0
156 stars 62 forks source link

Provide dockerpty.__version__ #75

Open yarikoptic opened 7 years ago

yarikoptic commented 7 years ago

I guess ATM should be assigned "0.4.1" Unfortunately there is no canonical way to setup version to be maintained in a single location but used within module and setup.py (although there are a bunch of versioneers projects), so please choose your favorite way ;) I found simplest is to have module/version.py to be imported into __init__.py and either parse or exec it. if you would like -- can do it that way for dockerpty

graingert commented 7 years ago

@yarikoptic __version__ is redundant. Use pkg_resources.get_distribution('dockerpty').version

yarikoptic commented 7 years ago

good point! So is it just historically happened that majority of modules provide it ? or may be to provide version information for naive / not-installed deployments where you merely point PYTHONPATH to the location of the module (hence no pkg_resources info)?

graingert commented 7 years ago

Yeah __version__ predates pkg_resources and packaging being good