flyspell-correct-ivy - Githubissues

d12frosted / flyspell-correct

Distraction-free words correction with flyspell via selected interface.

Other

200 stars 14 forks source link

flyspell-correct-ivy #65

Closed atanasj closed 4 years ago

atanasj commented 4 years ago

Hi,

The popup options with save to dictionary etc., have stopped working. Not sure why, I cannot get an error report out of it. However, when I press M-o, I get the text Suggestions for … in dictionary "Default":, but cannot see the options. Although, pressing one of the predefined options e.g., M-o b allows me to accept the word in buffer, but I just cannot see the options.

Here is my config:

  (use-package flyspell-correct-ivy
    :bind ("C-M-;" . flyspell-correct-wrapper)
    :init
    (setq flyspell-correct-interface #'flyspell-correct-ivy))

Anyway I can fix this? I'm on emacs 28.0.50 on MacOS.

Cheers.

d12frosted commented 4 years ago

Wow, this is interesting. I could not reproduce until I've upgraded all my packages.

Here is what I get when I invoke flyspell-correct-wrapper.

And here is what I get when I press M-o in that buffer.

Are you talking about the second case?

d12frosted commented 4 years ago

Btw, actually M-o stopped to work in many other cases. For example, counsel-find-file also doesn't have any options in M-o. Looks like an upstream bug.

@atanasj is this the case for you as well?

atanasj commented 4 years ago

Yes @d12frosted, I'm getting the same behaviour. I suppose we wait?

d12frosted commented 4 years ago

Can't reproduce on Emacs 26.3.

atanasj commented 4 years ago

Must be a but on Emacs 28.0.50… I suppose I should go back to 26.3... I only updated to the HEAD version because I was having problems with lsp-mode for ess, but they persist in 28.0.50…

atanasj commented 4 years ago

@d12frosted, do you think this is a but that will get corrected for use with the --HEAD version of Emacs?

d12frosted commented 4 years ago

I am not sure. I hadn't a chance to properly debug it and to understand the reason of breakage. I've opened an issue in swiper repo. And also checked the Emacs devel/bug mailing lists, but didn't find anything useful. Though I haven't spent much time on this.

atanasj commented 4 years ago

No worries. It would be great to get it working again… However, I get that 28.0.50 is the dev version and could change.

d12frosted commented 4 years ago

@atanasj workaround can be found here: https://github.com/abo-abo/swiper/issues/2444

atanasj commented 4 years ago

Thanks for that, I just installed ivy-hydra, and that seems to do the trick too. It's another dependency, but working none the less:

d12frosted commented 4 years ago

Fixed upstream.