d12frosted / homebrew-emacs-plus

Emacs Plus formulae for the Homebrew package manager
MIT License
2.35k stars 181 forks source link

emacs-plus was not built with native JSON support? #261

Closed AbstProcDo closed 4 years ago

AbstProcDo commented 4 years ago

I installed emacs-plus as:

brew install emacs-plus

It works fine with doom-emacs until run testing with doom docor

It report warning that Emacs was not built with native JSON support.

> Checking your Emacs version...
> Checking for Emacs config conflicts...
> Checking for great Emacs features...
! Emacs was not built with native JSON support
  Users will see a substantial performance gain by building Emacs with jansson
  support (i.e. a native JSON library), particularly LSP users. You must
  install a prebuilt Emacs binary with this included, or compile Emacs with
  the --with-json option.
> Checking for private config conflicts...
> Checking for stale elc files...
> Checking Doom Emacs...

Is it a decent warning? emacs-plus not come with native json support?

Should I uninstall emacs-plus and re-install it with emacs-plus --with-json

d12frosted commented 4 years ago

Not sure about meaning for doom emacs, but if you wish to install with native json support, please use --with-jansson option. Check options section of README for other available options.

kaz-yos commented 4 years ago

This should probably be an opt-out now that 27.1 defaults to its use.

https://www.masteringemacs.org/article/whats-new-in-emacs-27-1

The new configure option '--with-json' adds native support for JSON.
This uses the Jansson library.  The option is on by default; use
'./configure --with-json=no' to build without Jansson support.  The
new JSON functions 'json-serialize', 'json-insert',
'json-parse-string', and 'json-parse-buffer' are typically much faster
than their Lisp counterparts from json.el.
d12frosted commented 4 years ago

Good point, I will remove that options from Emacs 27 and Emacs 28.

iT-Boyer commented 1 year ago

@d12frosted emacs-plus@28 or newer,show this isses:json-parse-buffer

Error caused by user's config or system: ~/.doom.d/modules/app/eaf/config.el, ( @void-function json-parse-buffer)
d12frosted commented 1 year ago

@iT-Boyer make sure you have Jansson installed (it's part of Emacs+ dependencies, so you should have it). In the worst case just uninstall Emacs+ and install it again.

iT-Boyer commented 1 year ago

i install these, but have the issue!

$brew info emacs-plus@30
==> d12frosted/emacs-plus/emacs-plus@30: stable 30.0.50
/opt/homebrew/Cellar/emacs-plus@30/30.0.50 (4,261 files, 208MB) *
  Built from source on 2023-05-28 at 16:46:17 with: --with-xwidgets --with-imagemagick
From: https://github.com/d12frosted/homebrew-emacs-plus/blob/HEAD/Formula/emacs-plus@30.rb
==> Dependencies
Build: make ✔, autoconf ✔, gnu-sed ✔, gnu-tar ✔, grep ✔, awk ✔, coreutils ✔, pkg-config ✔, texinfo ✔, xz ✔
Required: gnutls ✔, librsvg ✔, little-cms2 ✔, jansson ✔, tree-sitter ✔
Optional: imagemagick ✔, dbus ✔, mailutils ✘

$ brew search Jansson      
==> Formulae
jansson ✔