d12frosted / homebrew-emacs-plus

Emacs Plus formulae for the Homebrew package manager
MIT License
2.24k stars 175 forks source link

Updates Formula to emacs 29.4 security fix #693

Closed gregnewman closed 1 week ago

gregnewman commented 1 week ago

@d12frosted

A security fix was pushed for emacs on June 22nd. This PR brings the Formula in alignment with 29.4.

gregnewman commented 1 week ago

@d12frosted I see someone else put in a PR also for this with the same failure on build with native comp. I'm not seeing anything in this codebase that needs changed (yet) and I'm also not seeing anything in the notes for 29.4 in the devel list. sha256 matches. but the error is related to pulling the cask Error: Failed to load cask: ./Formula/emacs-plus@29.rb

getong commented 1 week ago

I made #691 , which failed too.

gregnewman commented 1 week ago

I made #691 , which failed too.

@getong i saw that after the fact. If you look at #687 it fails also so it’s unrelated.

d12frosted commented 1 week ago

Oh. I merged the PR that was opened first. Sorry about that @gregnewman . But that you for opening this PR 🙏