search

d12frosted / vino

It's your cellar, your dear cantina.
GNU General Public License v3.0
37 stars 2 forks source link

feat: move volume property from bottle to wine entry #124

Closed d12frosted closed 3 weeks ago

d12frosted commented 3 weeks ago

Aside from giving a way to reflect the mere fact that some wines come in very specific bottle sizes (think of Radikon, Marsala, etc.), it also allows to distinguish wines of different size: price and rating-wise. And indeed, magnum bottles are often quite different - not only they do have their own evolution compared to normal bottles, sometimes they are even crafted differently (a common thing within Champagne).

So practically, thus also means that one should create separate wine entries for different volumes.

P.S. If you have troubles migrating, simply run the following SQL:

ALTER TABLE bottle DROP COLUMN volume;

There is no migration routine as I haven't seen users of vino-inv yet.

d12frosted commented 3 weeks ago

I will address the failing tests shortly™.