search

d13r / laravel-breadcrumbs

Please see the Diglactic fork.
https://github.com/diglactic/laravel-breadcrumbs
2.34k stars 416 forks source link

Wrong Readme Method parameter reference #182

Closed romanzipp closed 6 years ago

romanzipp commented 6 years ago

There are wrong method parameters listed for the Breadcrumbs::before() and Breadcrumbs::after() methods in the "Defining breadcrumbs" section inside the project README.md

Expected

Breadcrumbs::before(function (BreadcrumbsGenerator $trail) {}
Breadcrumbs::after(function (BreadcrumbsGenerator $trail) {}

Listed

Breadcrumbs::before('name', function (BreadcrumbsGenerator $trail) {}
Breadcrumbs::after('name', function (BreadcrumbsGenerator $trail) {}
Argument 1 passed to DaveJamesMiller\Breadcrumbs\BreadcrumbsManager::before() must be callable, string given, called in .../vendor/laravel/framework/src/Illuminate/Support/Facades/Facade.php on line 221