search

d13r / laravel-breadcrumbs

Please see the Diglactic fork.
https://github.com/diglactic/laravel-breadcrumbs
2.34k stars 416 forks source link

Add Laravel 5.8 support #203

Closed dabich closed 5 years ago

d13r commented 5 years ago

Tests seem to be failing so I can't merge it - but not just in the latest version, so I'm not sure why - but I don't have time to investigate right now.

ammonkc commented 5 years ago

I'm not sure if this is what's causing it to fail, but the deprecated array_first() helper method is being use here: https://github.com/davejamesmiller/laravel-breadcrumbs/blob/8e2ddef22bc0451f7b1df714c0de3c8ec20ec843/src/BreadcrumbsManager.php#L282

It should probably be updated to Arr::first()

According to the Laravel docs this helper method is deprecated:

All array* and str* global helpers have been deprecated. You should use the Illuminate\Support\Arr and Illuminate\Support\Str methods directly.

d13r commented 5 years ago

It should probably be updated to Arr::first()

Good idea.

lloricode commented 5 years ago

phpunit setUp() and tearDown() need to add return type :void

KubqoA commented 5 years ago

I think it isn't enough to just rollback the version of phpunit to 7 while leaving the void return type intact in the setup methods. I feel like you need to modify that as well. I would do it myself but I don't have the write privileges.

d13r commented 5 years ago

Good catch on the .travis.yml file. I'm just running some local tests then will merge & release it. Thanks!

d13r commented 5 years ago

All done.