search

d21spike / plugin.video.sling

Sling TV Add-On for Kodi
GNU General Public License v3.0
18 stars 14 forks source link

Add multiple accounts #19

Open crak3rjack opened 4 years ago

crak3rjack commented 4 years ago

@d21spike Request if it's possible to add more then one account to the existing addon or if you could make another fork to log in with a different and thanks.

GreatOwle commented 3 years ago

Hi, I was thinking on working on this because it looks like it'd be a pretty easy one to do. Can you please help me understand the request? What the root problem is that this would solve?

crak3rjack commented 3 years ago

@GreatOwle My request is about to add more than 1 account, Sling offers different packages...3 differents accounts if I can login to a sports package account, latino package account or international package account. I can login to all 3 and switch accounts inside the addon hope this answer is good enough and thanks for taking time to look at it.

GreatOwle commented 3 years ago

Yes, it does. TYVM @crak3rjack.

d21spike commented 3 years ago

@GreatOwle This isn't so much of an issue but an improvement as such more focus has been given to things such as current version of Inputstream.Adaptive breaking live playback and Sling changing the way it does scheduling playlist (guide) so certain channels have been failing with the following error ( related to #26 ):

image

@crak3rjack I've been thinking about how to best implement this. I'm not all to concerned about account sharing and whatnot. It's more-so how fundamentally almost everything about how channels are stored and retrieved has to change. Anytime you initiate playback for a channel, widevine licencing takes in the user id and the channel id to verify you're allowed to play this item. Having multiple accounts, not only do I have keep track of multiple user ID's, Subscription packages and which account they go to, geolocation, etc ... Also the database would need to match the subcription packages/channels to each account that way playback can function.

Currently any user related settings are stored in the addon settings file, a feature like this might require a separate file or just a lookup table.

GreatOwle commented 3 years ago

@crak3rjack I was thinking that it was just going to be an issue of adding some new text fields to the settings, figuring how how to load and save their states, and changing parameter values for a login function. It now seems that this is a larger issue than I thought and that it might not be the best first task for someone unfamiliar with the code.

@d21spike I agree that if there are stability issues then they should have priority over new features. Are there any issues that you would like me to look at specifically?

d21spike commented 3 years ago

@GreatOwle Take a look at issue #22 there is some testing to be done so more progress can be made.