d21spike / plugin.video.sling

Sling TV Add-On for Kodi
GNU General Public License v3.0
18 stars 14 forks source link

DVR/Recordings no longer work #47

Open IIMacGyverII opened 1 year ago

IIMacGyverII commented 1 year ago

When trying to enter My TV>Recordings you will receive an error stating to check the log for more details. I would include the log if I could find it but I am confident this error is coming from a recent change at Sling that also effects the Windows Store Sling app when trying to open the recordings in the same way. The official Windows Sling app now gives an error stating "Device is no longer supported. (15-15). This started happening simultaneously on both the Windows App and the Kodi Sling add-on just a few days ago. Very good bet they are related. Maybe a change on the Sling API?

I have tried this on multiple Windows Computers with the sling app and this Kodi add on as well on Windows Kodi, Android Kodi and Linux Kodi. iOS and Android Sling apps are working fine with the DVR/Recordings.

d21spike commented 1 year ago

I'll take look soon.

hagertyoh commented 1 year ago

The problem seems to be caused by special characters in the title of one of the recordings. Once the recording with special characters is deleted all works correctly again. As an example. Battlebots episode "ROBOTS, READY!!!“ caused an issue.

d21spike commented 1 year ago

@hagertyoh Can you provide me with the title of the recording with special characters? That should be something I can filter out.

I'll see if I can test the other one.

I tried Kodi 18.4 Win10, Kodi 19.3 Android, Kodi 19.5 Win10, Kodi 20-RC2 Win10, Kodi 20-RC2 Android ... they all seemed to play without issue.

hagertyoh commented 1 year ago

@d21spike The only one I know for sure was Battlebots Episode - ROBOTS, READY!!!

hagertyoh commented 1 year ago

This seems to be a really hit or miss as an issue. I cannot seem to pinpoint when the problem occurs.

slinguser commented 1 year ago

Problem confirmed on RPi4 and Linux. Unable to access recordings in MyTV. The referenced log file is for an attempt on a linux system.

Log file https://paste.kodi.tv/esazorosok.kodi

xags commented 1 year ago

@slinguser looks like the offending code is on line 505 in my_tv.py

    #if 'background_image' in program:
        #if 'url' in program['background_image']:
        #    if asset['Poster'] == ICON and program['background_image']['url'] is not None:
        #        asset['Poster'] = program['background_image']['url']

Commenting works around the issue but should be fixed. It looks like the metadata has changed causing the error.

randallspicher commented 1 year ago

@slinguser looks like the offending code is on line 505 in my_tv.py

    #if 'background_image' in program:
        #if 'url' in program['background_image']:
        #    if asset['Poster'] == ICON and program['background_image']['url'] is not None:
        #        asset['Poster'] = program['background_image']['url']

Commenting works around the issue but should be fixed. It looks like the metadata has changed causing the error.

I can confirm that commenting out lines pulling the background image fixes the recordings list.

hagertyoh commented 1 year ago

worked for me also. thanks for the fix