d21spike / plugin.video.sling

Sling TV Add-On for Kodi
GNU General Public License v3.0
19 stars 14 forks source link

Add closed caption support #7

Open eracknaphobia opened 4 years ago

d21spike commented 4 years ago

Sling includes Closed Captioning in two standards, CEA-608 and CEA-708. The closed captions are included within the steam, MPD file. Specifically toggling closed captions via the browser player uses "CC1."

<Accessibility schemeIdUri="urn:scte:dash:cc:cea-608:2015" value="CC1=eng"></Accessibility>  
<Accessibility schemeIdUri="urn:scte:dash:cc:cea-708:2015" value="1=lang:eng"></Accessibility>  

Looking for implementation within inputstream.adaptive, closest I find that is it looks for a role with a value of "subtitle" leading me to believe these standards are not implemented. He talks about it here: peak3d on Subtitles

<Role schemeIdUri="urn:mpeg:dash:role:2011" value="subtitle"/>
hackthis02 commented 4 years ago

Is there any update on this?

d21spike commented 4 years ago

@hackthis02 I've tried the suggestions from this post and wasn't able to have a working result.

In the above linked issue, at the very end the developer mentions that he added properties to address this but I've yet to see what he meant by this.