d2cml-ai / csdid

CSDID
https://d2cml-ai.github.io/csdid/index.html
MIT License
23 stars 6 forks source link

Typo in function name _pre_process_did on line 71 #14

Closed flowerpower13 closed 1 year ago

flowerpower13 commented 1 year ago

The function _pre_process_did currently contains a typo in its parameter name on line 71. The parameter "nfirstperiod" should be replaced with "nfirst_period". This appears to be a simple typographical error that might have unintended consequences or cause confusion for users who interact with this function.

Steps to Reproduce:

Navigate to the file containing the _pre_process_did function. Locate the function definition. Examine the parameter list on line 71.