d2cml-ai / csdid

CSDID
https://d2cml-ai.github.io/csdid/index.html
MIT License
23 stars 6 forks source link

PR to implement unit tests against `R::did` via `rpy2` #38

Open s3alfisc opened 2 months ago

s3alfisc commented 2 months ago

Hi @alexanderquispe , thanks for your work, the package looks great!

Would you be interested in a basic PR that sets up basic tests + a CI workflow against the R package by means of rpy2? This is what I've been doing with pyfixest and it has turned out to be quite useful for me =)

The github action would look similar to pyfixest's, which you can find here.

Best, Alex

pedrohcgs commented 2 months ago

Yes, please!!!!


Pedro H. C. Sant'Anna https://psantanna.com https://psantanna.com


Warning: This email may contain confidential or privileged information intended only for the use of the individual or entity to whom it is addressed. If you are not the intended recipient, please understand that any disclosure, copying, distribution, or use of the contents of this email is strictly prohibited.

On Sun, Sep 22, 2024 at 11:37 Alexander Fischer @.***> wrote:

Hi @alexanderquispe https://github.com/alexanderquispe , thanks for your work, the package looks great!

Would you be interested in a basic PR that sets up basic tests + a CI workflow against the R package by means of rpy2? This is what I've been doing with pyfixest and it has turned out to be quite useful for me =)

The github action would look similar to pyfixest's, which you can find here https://github.com/py-econometrics/pyfixest/blob/5bf8cc9c684061ce0bbca5179aaf983439c8573e/.github/workflows/ci-tests.yaml#L39 .

Best, Alex

— Reply to this email directly, view it on GitHub https://github.com/d2cml-ai/csdid/issues/38, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABE7345OWK3M6MJWVWXXKNDZX3P25AVCNFSM6AAAAABOUVDKFOVHI2DSMVQWIX3LMV43ASLTON2WKOZSGU2DCMJTGQYTIOI . You are receiving this because you are subscribed to this thread.Message ID: @.***>

s3alfisc commented 2 months ago

Great, I added a wfl with a small test against R::did for ATEs in #39 =)

alexanderquispe commented 1 month ago

@s3alfisc thanks a lot for this!

s3alfisc commented 1 month ago

My pleasure @alexanderquispe =)