d2iq-archive / dcos-flink-service

11 stars 17 forks source link

Add setting for `containerized.heap-cutoff-min` to service settings #5

Open Makman2 opened 7 years ago

Makman2 commented 7 years ago

Especially this setting limits other memory settings, so this config-value should be definitely allowed to change.

Makman2 commented 7 years ago

This happens for example when choosing wrong memory settings:

java.lang.IllegalArgumentException: The configuration value 'containerized.heap-cutoff-min'='600' is larger than the total container memory 510
    at org.apache.flink.runtime.clusterframework.ContaineredTaskManagerParameters.create(ContaineredTaskManagerParameters.java:131)
    at org.apache.flink.mesos.runtime.clusterframework.MesosTaskManagerParameters.create(MesosTaskManagerParameters.java:126)
    at org.apache.flink.mesos.runtime.clusterframework.MesosApplicationMasterRunner.runPrivileged(MesosApplicationMasterRunner.java:229)
    at org.apache.flink.mesos.runtime.clusterframework.MesosApplicationMasterRunner$1.call(MesosApplicationMasterRunner.java:178)
    at org.apache.flink.mesos.runtime.clusterframework.MesosApplicationMasterRunner$1.call(MesosApplicationMasterRunner.java:175)
    at org.apache.flink.runtime.security.NoOpSecurityContext.runSecured(NoOpSecurityContext.java:29)
    at org.apache.flink.mesos.runtime.clusterframework.MesosApplicationMasterRunner.run(MesosApplicationMasterRunner.java:175)
    at org.apache.flink.mesos.runtime.clusterframework.MesosApplicationMasterRunner.main(MesosApplicationMasterRunner.java:135)

When implementing this setting, mention also in the description for TM-memory that the value has to be larger than conainerized.heap-cutoff-min.