Make delay queue tests time independent

d2iq-archive / kubernetes-mesos

A Kubernetes Framework for Apache Mesos

636 stars 92 forks source link

Make delay queue tests time independent #432

Open jdef opened 9 years ago

jdef commented 9 years ago

[ ] re-enable delay queue unit tests:
- TestDQ_always_pop_earliest_deadline_multi
- TestDQ_always_pop_earliest_deadline
[ ] make them independent of a true time source

Compare Shippable flakes in (now closed because they never showed up again on Jenkins):

jdef commented 9 years ago

possibly needs a rewrite since it's very hard to test; API is timeout based, difficult to test in a heavily loaded CI environment

jdef commented 8 years ago

did they not show up because the tests were disabled?

sttts commented 8 years ago

Yes, both tests are disabled for quite some time. So we don't know.

jdef commented 8 years ago

The code hasn't really changed since the tests were disabled, so I'm pretty confident that the test flakes are still there

On Mon, Nov 30, 2015 at 12:28 PM, Dr. Stefan Schimanski < notifications@github.com> wrote:

Yes, both tests are disabled for quite some time. So we don't know.

— Reply to this email directly or view it on GitHub https://github.com/mesosphere/kubernetes-mesos/issues/432#issuecomment-160697120 .

karlkfi commented 8 years ago

I have a branch and local code with changes, but it became a giant hairy mess, and I had more important things to get to. So I put it on hold.