search

d2iq-archive / kubernetes-mesos

A Kubernetes Framework for Apache Mesos
636 stars 92 forks source link

host_port_endpoints is deprecated #785

Closed jdef closed 8 years ago

jdef commented 8 years ago

Flags should be using - delimiters instead of _.

Also the controller-manager uses this flag to determine endpoint generation, but the scheduler does NOT use this flag to determine the default port mapping strategy. There's a disconnect here.

xref https://github.com/kubernetes/kubernetes/pull/21276

jdef commented 8 years ago

also, wondering if the kubelet-executor should also have this flag, to control (at least) the func in executor/registry that preserves container ports across pod updates -- there's no need for this code to execute if we're doing doing any kind of dynamic port assignment.

jdef commented 8 years ago

decided against passing the flag to the kubelet; we'll stay conservative for now, blocking any changes to pod container network configuration once it's launched.

jdef commented 8 years ago

cherry-picked into v0.7.3, removing cherry-pick label