search

d2iq-archive / marathon

Deploy and manage containers (including Docker) on top of Apache Mesos at scale.
https://mesosphere.github.io/marathon/
Apache License 2.0
4.07k stars 843 forks source link

COPS-6533 Fix issue in which PUT /v2/groups ignored the enforceRole setting #7234

Closed timcharper closed 4 years ago

timcharper commented 4 years ago

Also, remove the default values for Group and RootGroup production model constructors so that this type of issue does not reoccur.

JIRA Issues: MARATHON-8770

timcharper commented 4 years ago

This PR builds on top of https://github.com/mesosphere/marathon/pull/7224

pierrebeitz commented 4 years ago

benchmarks don't compile. @timcharper it would be awesome to have Builders within the benchmark tests. most likely that's pretty straightforward, but: how would i do that?

run sbt benchmark/compile to see stuff failing

timcharper commented 4 years ago

Sigh, I spent way too much time trying to get Builders working in benchmark repo. SBT supports dependencies for benchmark main to depend on marathon test, but IntelliJ does not support it and gives all kinds of false negatives: https://youtrack.jetbrains.com/issue/SCL-8396

I tried extracting test-utils and having marathon test depend on test-utils, and test-utils depend on marathon main, but this resulted in a cyclic dependency error :/

So, I just went with symlinking in the end. Kind of a hack, but it works. Could copy-and-paste also :/