Support non-standard ports for upstreams

[drewkerrigan]

• Modifies master / resolver validation to reuse more code
• Master / resolver validation now mutate source lists with normalized values for more efficient usage
• Implements #459

[drewkerrigan]

@jdef yes your original comment makes more sense now :-).

I assume you'd prefer that approach to having mutation occur with the validation? Cc: @sargun

[jdef]

Right, a validate() func shouldn't mutate.

On Sun, Aug 28, 2016 at 11:46 AM, Drew Kerrigan notifications@github.com wrote:

@jdef https://github.com/jdef yes your original comment makes more sense now :-).

I assume you'd prefer that approach to having mutation occur with the validation? Cc: @sargun https://github.com/sargun

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/mesosphere/mesos-dns/pull/468#issuecomment-242981764, or mute the thread https://github.com/notifications/unsubscribe-auth/ACPVLHjdbj_GKvJjzOFc6MFIO-PF_He-ks5qka1pgaJpZM4Juvql .

[drewkerrigan]

@sargun agree with your comments, they've been addressed

[drewkerrigan]

@sargun @jdef I've addressed your above comments, please check out the latest changes.

[jdef]

lgtm

[drewkerrigan]

@sargun Please take another look when you get a chance - this should make it to master before https://github.com/dcos/dcos/pull/606 gets merged ideally.

[sargun]

One nit, but otherwise, looks good.

[sargun]

Can you squash?