search

d2iq-archive / mesos-dns

DNS-based service discovery for Mesos.
https://mesosphere.github.com/mesos-dns
Apache License 2.0
483 stars 137 forks source link

use container ports in tasks SRV records #519

Open vixns opened 6 years ago

mesosphere-ci commented 6 years ago

Can one of the admins verify this patch?

vixns commented 6 years ago

UseContainerPorts is not a good name, SRVTaskRecordsUseContainerPortsWithNetinfo has a better semantic, but may be too long, any idea for a better option name ?

jdef commented 6 years ago

SRVPreferContainerPorts ?

On Tue, May 8, 2018 at 8:16 AM, vixns notifications@github.com wrote:

UseContainerPorts is not a good name, SRVTaskRecordsUseContainerPort sWithNetinfo has a better semantic, but may be too long, any idea for a better option name ?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/mesosphere/mesos-dns/pull/519#issuecomment-387382879, or mute the thread https://github.com/notifications/unsubscribe-auth/ACPVLNVFzvxHjE-X_sbjCPGLdDcaPes0ks5twYy7gaJpZM4T2Y79 .

mesosphere-ci commented 6 years ago

Can one of the admins verify this patch?

vixns commented 5 years ago

oops rebased on wrong branch, sorry. Re-rebased and force pushed.