Closed bwplotka closed 9 years ago
I don't like the way current bus demands changes in filter's code (it should not add demand if/elses). Also it MIGHT be better if it implements Akka-style topic-based subscription (message class subscription could be too wide...) and before we start to use it, we should move all our filters to libprocess, so they could be easily connected to bus... Do we want it now?
Some of the issues (filters code change) could be solved by having multiple instances of bus, or topic-based subscription, but we are not there yet.
string
classifier to this EventBus. (:I dislike both buses :) - each from different reasons. I think we shouldn't add topic yet - we are able to live without it now (and I'm a little afraid of it's possible drawbacks eg. hardcoding dependencies between filters inside filter code) - but it would be lovely if we carefully designed whole transition from Producer-Consumer to Topic-based bus pipelines. To avoid too much code tanglement, we should use bus only for inter-pipeline communication (it should be stated in doc). Please fix the mutlithreading parts, and we should be good to go.
Rdy for 2nd review @skonefal
Last nits repaired.
LGTM
LGTM
Notes about the bus (from doc)
Based on Szymon's bus: https://github.com/mesosphere/serenity/pull/91
This PR includes integration with ValveFilter.
Tested in real flow.