search

d2l-ai / d2l-book

Books with Jupyter notebooks
https://book.d2l.ai/
Apache License 2.0
230 stars 96 forks source link

Fix #48: Improve version reading & bump mxtheme dep version #53

Closed AnirudhDagar closed 2 years ago

AnirudhDagar commented 2 years ago

Reference Issue: https://github.com/d2l-ai/d2l-book/issues/48 Reference Fix: https://github.com/mli/mx-theme/pull/8

A few minutes ago mxtheme was updated in https://github.com/mli/mx-theme/pull/8 to fix the root problem. Soon mx-theme==0.3.17 should be available on pypi. Once that is there, this PR can be merged and #48 can be closed.

cc @astonzhang @mli

AnirudhDagar commented 2 years ago

Ahh, this will break the CI atm since mxtheme==0.3.17 is not yet up on pypi. hence i suggested to wait for that before merging. @mli could you please do that whenever you have time? Thanks!

astonzhang commented 2 years ago

@AnirudhDagar I've reverted this change https://github.com/d2l-ai/d2l-book/commit/0b1f63504d37dad7b1ab75aede6ae9c89f6398b6

Once mxtheme==0.3.17 is on pypi, could you resend this PR for merging?

AnirudhDagar commented 2 years ago

Cool, sounds good!

mli commented 2 years ago

uploaded mxtheme, please verify if the new version works

On Wed, Jun 29, 2022 at 4:23 PM Anirudh Dagar @.***> wrote:

Cool, sounds good!

— Reply to this email directly, view it on GitHub https://github.com/d2l-ai/d2l-book/pull/53#issuecomment-1170588691, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADG7YLGK6Z33HLGE2DC2ILVRTLHVANCNFSM52HFOTSQ . You are receiving this because you were mentioned.Message ID: @.***>

AnirudhDagar commented 2 years ago

I just ran a build on d2l-en here after deleting the environment manually. It is all green and the installation goes through smoothly, I can verify that the issue is resolved. Thanks Mu!