search

d2l-ai / d2l-en

Interactive deep learning book with multi-framework code, math, and discussions. Adopted at 500 universities from 70 countries including Stanford, MIT, Harvard, and Cambridge.
https://D2L.ai
Other
23.92k stars 4.36k forks source link

Doc string for dataloader in "image-classification-dataset" part #1211

Closed Yijia-Xiao closed 4 years ago

Yijia-Xiao commented 4 years ago

Dear Professor/authors: I am not sure whether I've mis-understood the meaning.

The doc string in chapter_linear-networks/image-classification-dataset.ipynb says:

def get_dataloader_workers():  #@save
    """Use 4 processes to read the data expect for Windows."""

But I think maybe except for will be less ambiguous than expect for, especially for those non-native English speakers.

I am a student learning d2l, it is a really amazing book, making deep learning interesting and is friendly to beginners! And I really hope it will become better and better!

Best wishes!

Yours sincerely, Yijia Shaw

astonzhang commented 4 years ago

Good catch! Would you like to send a PR to fix it? See how here: https://d2l.ai/chapter_appendix-tools-for-deep-learning/contributing.html

Yijia-Xiao commented 4 years ago

Sure! I have just made a PR, for your reference :)

astonzhang commented 4 years ago

Could you point me to your PR?

Yijia-Xiao commented 4 years ago

Oh, because I am not that familiar with Pull Request. So I just make a PR 2 days ago, but didn't submit it correctly. The PR is https://github.com/d2l-ai/d2l-en/pull/1215 I am sorry for being late.

astonzhang commented 4 years ago

Thanks for being a contributor to D2L! https://github.com/d2l-ai/d2l-en/commit/b767e858885e9ee0125d2680181652371e19629b#diff-12c91c71c89f53d4c79132aefe798e57R426

Yijia-Xiao commented 4 years ago

Thank you! Hope D2L will become better and better, making more people enjoy Deep Learning!