FIXME that should be fixed

[astonzhang]

• FIXME, don’t use Sequential to implement MySequential. in http://preview.d2l.ai.s3-website-us-west-2.amazonaws.com/d2l-en/master/chapter_deep-learning-computation/model-construction.html

[terrytangyuan]

Could you clarify? Currently the implementation of MySequential does not use Sequential.

class MySequential(tf.keras.Model):
    def __init__(self, *args):
        super().__init__()
        self.modules = []
        for block in args:
            # Here, `block` is an instance of a `tf.keras.layers.Layer`
            # subclass
            self.modules.append(block)

    def call(self, x):
        for module in self.modules:
            x = module(x)
        return x

[astonzhang]

It seems that this FIXME is added by Mu. @mli, shall we update this FIXME?

[terrytangyuan]

Yes this has been resolved before our announcement of TF implementation. Where did you see the FIXME?

[astonzhang]

Just click the link and turn on tf tab, ctrl + F "FIXME".